df/webif
1
0
Fork 0
forked from hummypkg/webif
Code Issues Pull Requests Releases Wiki Activity

Fix potential format error with queue item containing % #3

Manually merged
af123 merged 9 commits from df-auto-deq-patch into master 2020-10-18 14:06:43 +00:00
Conversation 0 Commits 9 Files Changed 5 +45 -17
df commented 2020-06-30 03:42:02 +00:00
Owner
Copy Link

If an item is in the queue whose file name contains a %, the following error occurs, causing the item never to be dequeued:

in procedure '::auto::dumpq' called at file "/mod/webif/lib/auto/deq", line 167
at file "/mod/webif/lib/auto/deq", line 118
/mod/webif/lib/auto/deq:118: Error: not enough arguments for all format specifiers

As a result, URLs containing URL-encoded characters (eg %20) are never processed by qtube.

The file name needs to be passed to format as a parameter with format %s rather than embedding it in the format string, or else log "[format ...][$q get file]".

If an item is in the queue whose file name contains a %, the following error occurs, causing the item never to be dequeued: ``` in procedure '::auto::dumpq' called at file "/mod/webif/lib/auto/deq", line 167 at file "/mod/webif/lib/auto/deq", line 118 /mod/webif/lib/auto/deq:118: Error: not enough arguments for all format specifiers ``` As a result, URLs containing URL-encoded characters (eg `%20`) are never processed by qtube. The file name needs to be passed to `format` as a parameter with format `%s` rather than embedding it in the format string, or else `log "[format ...][$q get file]"`.
af123 manually merged commit 879c458256 into master 2020-10-18 14:06:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: df/webif#3
No description provided.
Delete Branch "df-auto-deq-patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?