df/zeroconf
1
0
Fork 0
Code Issues 7 Pull Requests 1 Releases Wiki Activity

Ensure sufficient buffer size when converting nlabels to string.

Browse Source
This commit is contained in:
Darell Tan 2017-11-05 00:02:07 +08:00
parent 4bed5363e7
commit db4e276662
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
mdns.c
View File

@ -90,18 +90,26 @@ uint8_t *join_nlabel(const uint8_t *n1, const uint8_t *n2) {
char *nlabel_to_str(const uint8_t *name) {
char *label, *labelp;
const uint8_t *p;
size_t buf_len = 256;
assert(name != NULL);
label = labelp = malloc(256);
label = labelp = malloc(buf_len);
for (p = name; *p; p++) {
strncpy(labelp, (char *) p + 1, *p);
labelp += *p;
uint8_t label_len = *p;
if (buf_len <= label_len)
break;
strncpy(labelp, (char *) p + 1, label_len);
labelp += label_len;
*labelp = '.';
labelp++;
p += *p;
buf_len -= label_len + 1;
p += label_len;
}
*labelp = '\0';