hummypkg/webif
5
3
Fork 4
Code Issues Pull Requests Releases 1 Activity

prpr-patch-rename-utf8 #20

Merged
af123 merged 2 commits from :prpr-patch-rename-utf8 into master 2020-10-19 22:02:43 +00:00
Conversation 1 Commits 2 Files Changed 1 +3
prpr commented 2020-10-19 16:06:24 +00:00
Owner
Copy Link

Allows renames to work properly with non-ASCII characters
https://hummy.tv/forum/threads/webif-web-interface-1-4-x.7712/post-135917

Allows renames to work properly with non-ASCII characters https://hummy.tv/forum/threads/webif-web-interface-1-4-x.7712/post-135917
af123 merged commit e3f7a2b738 into master 2020-10-19 22:02:39 +00:00
df commented 2020-12-31 15:28:27 +00:00
Owner
Copy Link

There are some problems here, because the title and synopsis fields have a maximum length. The maximum is enforced in the UI by the maxlength attribute of the <input> elements. It's also supposed to be enforced in the ts settitle and ts setsynopsis methods, but there are missing $s that break that. Finally the hmt program prints a diagnostic (as usual no error code) and refuses to overflow the available length.

Example:
"America's Untold Story E3 The British Are Coming"
"123456789012345678901234567890123456789012345678"
This is accepted by the UI but can't be set as a title because "\025America's Untold Story E3 The British Are Coming" is 49 characters.

So we need to reduce the UI length by 1 for title and synopsis. See #30.

Does "guidance" need the same treatment?

There are some problems here, because the title and synopsis fields have a maximum length. The maximum is enforced in the UI by the `maxlength` attribute of the `<input>` elements. It's also supposed to be enforced in the `ts settitle` and `ts setsynopsis` methods, but there are missing $s that break that. Finally the `hmt` program prints a diagnostic (as usual no error code) and refuses to overflow the available length. Example: "America's Untold Story E3 The British Are Coming" "123456789012345678901234567890123456789012345678" This is accepted by the UI but can't be set as a title because "\025America's Untold Story E3 The British Are Coming" is 49 characters. So we need to reduce the UI length by 1 for title and synopsis. See https://git.hpkg.tv/hummypkg/webif/pulls/30. Does "guidance" need the same treatment?
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hummypkg/webif#20
No description provided.
Delete Branch ":prpr-patch-rename-utf8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?