hummypkg/webif
5
3
Fork 4
Code Issues Pull Requests Releases 1 Activity

Change schedule list to use svc.class instead of get_channel_attr_byhsvc #4

Merged
af123 merged 1 commits from :schedlist into master 2020-06-03 09:59:32 +00:00
Conversation 0 Commits 1 Files Changed 1 +3 -4
MymsMan commented 2020-05-11 15:52:56 +00:00
Contributor
Copy Link

Schedule list webif page was failing if the channel for an episode differed from the channel for the series.

This was because it was using get_channel_attr_byhsvc to retrieve the channel name and was implicitly depending on rsv.class to require findhsvc which has been removed

This has now been changed to now use the new svc.class directly

AFAIK this was the last remaining use of get_channel_attr... within the webif package

Note: Had problems with indentation, 1st attempt caused over 300 lines to be flagged as changed, 2nd attempt shows different indentation in editor and web views.
I think there must be tab expansion differences

Schedule list webif page was failing if the channel for an episode differed from the channel for the series. This was because it was using get_channel_attr_byhsvc to retrieve the channel name and was implicitly depending on rsv.class to require findhsvc which has been removed This has now been changed to now use the new svc.class directly AFAIK this was the last remaining use of get_channel_attr... within the webif package Note: Had problems with indentation, 1st attempt caused over 300 lines to be flagged as changed, 2nd attempt shows different indentation in editor and web views. I think there must be tab expansion differences
af123 changed title from Change scedule list to use svc.class instead of get_channel_attr_byhsvc to Change schedule list to use svc.class instead of get_channel_attr_byhsvc 2020-06-03 09:55:51 +00:00
af123 closed this pull request 2020-06-03 09:59:32 +00:00
MymsMan deleted branch schedlist 2020-06-03 11:43:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#4
No description provided.
Delete Branch ":schedlist"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?