WIP:df-epgpopup-patch #5

df · 2020-05-17T14:08:10Z

df commented

2020-05-17 14:08:10 +00:00

Test patch to change button handling in the WebIf programme details pop-up:

Remove "Record Programme" button if programme has started.
Rename "Set Reminder" button to "Watch Now" if programme is showing.
Remove all the above if the programme has finished.

Test patch to change button handling in the WebIf programme details pop-up: 1. Remove "Record Programme" button if programme has started. 1. Rename "Set Reminder" button to "Watch Now" if programme is showing. 1. Remove all the above if the programme has finished.

MymsMan commented

2020-05-17 15:01:09 +00:00

Remove “Record Programme” button if programme has started.

Not a good idea - since you can actually record a programme after it has started which can be usefull

If you only realise it is on at last moment
If the humax has just restarted after crashing
...

Possibly change label to "Record active programme"

Remove “Record Programme” button if programme has started. Not a good idea - since you can actually record a programme after it has started which can be usefull * If you only realise it is on at last moment * If the humax has just restarted after crashing * ... Possibly change label to "Record active programme"

MymsMan commented

2020-05-17 15:07:06 +00:00

A usefull change in this area would be to show "Cancel recording" "Skip" "Swich to alternate" buttons from the 'Visual Schedule" popups if a programme has been scheduled for recording

df commented

2020-05-17 19:23:55 +00:00

Yes, "Record Programme" would be a better way to recover than "Watch Now" followed by Record (or IR Record) if the box is being managed out of eyeshot.

It doesn't seem to be easy to "change" the button name in jQ UI, but I am not an expert. Seems like you can either set up all possible buttons for the dialogue (an Object structure like { button1_label: action1(), button2_label: action2(), ...}) and then delete the dynamically unwanted ones, or add the dynamically wanted buttons to a base structure each time.

Seems like there's an opportunity to unify the epgpopup code for Visual Schedule and EPG? Otherwise perhaps could fake into the VS pop-up from the EPG one for scheduled recordings?

Yes, "Record Programme" would be a better way to recover than "Watch Now" followed by Record (or IR Record) if the box is being managed out of eyeshot. It doesn't seem to be easy to "change" the button name in jQ UI, but I am not an expert. Seems like you can either set up all possible buttons for the dialogue (an Object structure like { button1_label: action1(), button2_label: action2(), ...}) and then delete the dynamically unwanted ones, or add the dynamically wanted buttons to a base structure each time. Seems like there's an opportunity to unify the epgpopup code for Visual Schedule and EPG? Otherwise perhaps could fake into the VS pop-up from the EPG one for scheduled recordings?

df closed this pull request

2020-06-05 16:30:03 +00:00

af123 referenced this issue from a commit

2020-11-14 11:16:56 +00:00

Merge pull request 'Resync master' (#5) from hummypkg/webif:master into master Reviewed-on: https://git.hpkg.tv/df/webif/pulls/5

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#5