df/youtube-dl
1
0
Fork 0
Code Issues Pull Requests 2 Releases 2 Wiki Activity

Fix bbc.co.uk playlist support #23438 #2

Open
df wants to merge 1 commits from djcsdy-bbcplaylist-patch into Hummy
pull from: djcsdy-bbcplaylist-patch
merge into: df:Hummy
Conversation 0 Commits 1 Files Changed 1 +69 -31
df commented 2020-10-17 00:18:53 +00:00
Owner
Copy Link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

This PR fixes two problems:

  • Downloading playlists from BBC iPlayer did not work at all due to the page layout changing completely since the extractor was written.

  • Downloading playlists from other parts of bbc.co.uk was partially broken – only the first page would be downloaded due to some whitespace being inserted between elements since the extractor was written.

Example URLs:

## Please follow the guide below - You will be asked some questions, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x]) - Use *Preview* tab to see how your *pull request* will actually look like --- ### Before submitting a *pull request* make sure you have: - [x] At least skimmed through [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site) and [youtube-dl coding conventions](https://github.com/ytdl-org/youtube-dl#youtube-dl-coding-conventions) sections - [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests - [x] Checked the code with [flake8](https://pypi.python.org/pypi/flake8) ### In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under [Unlicense](http://unlicense.org/). Check one of the following options: - [ ] I am the original author of this code and I am willing to release it under [Unlicense](http://unlicense.org/) - [x] I am not the original author of this code but it is in public domain or released under [Unlicense](http://unlicense.org/) (provide reliable evidence) ### What is the purpose of your *pull request*? - [x] Bug fix - [x] Improvement - [ ] New extractor - [ ] New feature --- This PR fixes two problems: * Downloading playlists from BBC iPlayer did not work at all due to the page layout changing completely since the extractor was written. * Downloading playlists from other parts of bbc.co.uk was partially broken – only the first page would be downloaded due to some whitespace being inserted between elements since the extractor was written. Example URLs: * https://www.bbc.co.uk/programmes/b00mfl7n/clips (All 142 clips should be downloaded, not just the first 24) * https://www.bbc.co.uk/programmes/b00mfl7n/clips?page=3 (Only the 24 clips on the specified page should be downloaded) * https://www.bbc.co.uk/iplayer/episodes/b07xd230/josh (All 18 episodes should be downloaded) * https://www.bbc.co.uk/iplayer/episodes/b07xd230/josh?seriesId=p047lvcs (Only the six episodes of season 2 should be downloaded) * https://www.bbc.co.uk/iplayer/episodes/b06kw5fq/scot-squad (Should download whatever episodes are currently available, time sensitive)
This pull request has changes conflicting with the target branch.
  • youtube_dl/extractor/bbc.py
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin djcsdy-bbcplaylist-patch:djcsdy-bbcplaylist-patch
git checkout djcsdy-bbcplaylist-patch
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: df/youtube-dl#2
No description provided.
Delete Branch "djcsdy-bbcplaylist-patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?