Crop UI enhancements #38

df · 2021-02-23T00:44:47Z

df commented

2021-02-23 00:44:47 +00:00

Some small improvements to the Crop recording page:

give the cut plan a minimum width in case the other fields in the column don't make it at least 500px wide;
make cut plan segments align left so as not to overflow that minimum width;
show/hide the estimated time field in line with the selected action;
check that bookmark save succeeded; if not, enable the old Save new bookmarks button;
add icons for buttons;
don't use negative CSS widths;
make the <label> for the Save Bookmarks checkbox actually be its label;
modify the invert routine to avoid re-encoding the page address.

Some small improvements to the `Crop recording` page: * give the cut plan a minimum width in case the other fields in the column don't make it at least 500px wide; * make cut plan segments align left so as not to overflow that minimum width; * show/hide the estimated time field in line with the selected action; * check that bookmark save succeeded; if not, enable the old `Save new bookmarks` button; * add icons for buttons; * don't use negative CSS widths; * make the `<label>` for the Save Bookmarks checkbox actually be its label; * modify the invert routine to avoid re-encoding the page address.

df added 5 commits 2021-02-23 00:44:48 +00:00

Allow minimum width for cut plan e43598a23e

Also 
* add ID for estimated time row
* make the <label> for the Save Bookmarks checkbox actually be its label.

Check that bookmark save succeeded cc5a9d6df1

If not, enable the old "Save new bookmarks" button.

Also
* add icons for buttons
* simplify invert URL handling.

Avoid negative CSS widths 805b90a591

Ensure cut plan segments are aligned left f824b0c25c

Avoid negative CSS widths c372c806e6

af123 commented

2021-02-24 12:28:12 +00:00

I have merged this into master by hand, adjusting the whitespace to match the rest of the project. This makes the diffs much smaller and it's easier to see what has actually changed.

af123 closed this pull request

2021-02-24 12:28:12 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#38